Fix Windows wheel dev version with SETUPTOOLS_SCM_PRETEND_VERSION#38
Merged
Fix Windows wheel dev version with SETUPTOOLS_SCM_PRETEND_VERSION#38
Conversation
CIBW_BEFORE_BUILD_WINDOWS runs in the project directory (no container isolation), so swig still dirties the git tree. Capture the clean version before swig runs and pass it via SETUPTOOLS_SCM_PRETEND_VERSION so setuptools-scm skips git describe entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CIBW_ENVIRONMENT_WINDOWS: SETUPTOOLS_SCM_PRETEND_VERSIONso setuptools-scm uses the tag versionmykytea_wrap.cxx(tracked file, different swig version) makes the tree dirty, causing0.1.12.dev0instead of0.1.11Test plan
kytea-0.1.11-cp310-cp310-win_amd64.whl)🤖 Generated with Claude Code