Conversation
- Extract CIBW_BEFORE_ALL_LINUX into linux-before-all.sh for readability - Remove unused CIBW_BEFORE_ALL_MACOS no-op - Compact matrix with YAML flow-style entries - Bump GHA actions (checkout v6, setup-python v6, upload-artifact v7, download-artifact v8) to fix Node.js 20 deprecation - Add post-build wheel sanity check (test-wheel.py) that imports the C extension and runs tokenization on all platforms - Fix pre-existing swig issues: - Add swig to macOS brew deps (removed from runner image in 2024) - Run swig on Windows to generate Mykytea.py wrapper - Download KyTea model on Windows for full tokenization test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors and strengthens the wheel-build CI by extracting Linux “before all” logic into a script, adding a post-build wheel sanity test (import + tokenization) across platforms, and modernizing the GitHub Actions workflow configuration (including action version bumps and a compacted matrix).
Changes:
- Extract Linux build prerequisites into
.github/workflows/linux-before-all.shand remove the unused macOS no-op hook. - Add
.github/workflows/test-wheel.pyand run it viacibuildwheeltest commands (with a Windows model download to enable full tokenization). - Update GitHub Actions action major versions and compact the matrix entries.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/wheels.yml |
Compacts matrix, bumps actions, adds Windows prep (SWIG + model) and runs wheel sanity tests via cibuildwheel. |
.github/workflows/test-wheel.py |
New wheel sanity test script validating import and tokenization. |
.github/workflows/macos-build.sh |
Ensures swig is installed on macOS runners before building. |
.github/workflows/linux-before-all.sh |
New extracted Linux dependency/build script for SWIG + KyTea + wrapper generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CIBW_BEFORE_ALL_LINUXinline commands intolinux-before-all.shfor readabilitytest-wheel.py) that runs tokenization after each wheel build on all platformsCIBW_BEFORE_ALL_MACOSno-op from YAMLswigto macOS brew dependencies (removed from runner image since 2024)swigon Windows to generateMykytea.pywrapperTest plan
🤖 Generated with Claude Code