When connection queue is full, respond with a 503 error. #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 21 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
itamarst
force-pushed
the
503-when-overloaded
branch
2 times, most recently
from
05f2bee to
57206a1
Compare
webknjaz
reviewed
May 27, 2025
webknjaz
reviewed
May 27, 2025
webknjaz
reviewed
May 27, 2025
webknjaz
reviewed
May 27, 2025
webknjaz
reviewed
May 27, 2025
itamarst
force-pushed
the
503-when-overloaded
branch
3 times, most recently
from
ead7721 to
97a6317
Compare
|
So now it ... fails, but not as consistently? I don't really know. |
|
Any other thoughts? It's pretty annoying that it passes some of the time but not all the time. |
itamarst
force-pushed
the
503-when-overloaded
branch
from
45698b9 to
4a5abc5
Compare
|
Looks like we're down to only 3.14 failing, which were already failing on |
webknjaz
reviewed
Jun 13, 2025
|
|
||
| def test_overload_results_in_suitable_http_error(request): | ||
| """A server that can't keep up with requests returns a 503 HTTP error.""" | ||
| localhost = '127.0.0.1' |
There was a problem hiding this comment.
I think it might be possible to import a constant with this from somewhere.
| def serve(self): | ||
| """Serve requests, after invoking :func:`prepare()`.""" | ||
| threading.Thread(target=self._serve_unservicable).start() |
There was a problem hiding this comment.
Do we need to wait for the thread to complete somewhere?
There was a problem hiding this comment.
... Probably not? other way around, it's possible it should be a daemon thread if you don't want sending 503s to delay shutdown of a process.
| def _serve_unservicable(self): | ||
| """Serve connections we can't handle a 503.""" | ||
| while self.ready: | ||
| conn = self._unservicable_conns.get() |
There was a problem hiding this comment.
Assuming stop() is always used, then no.
| while self.ready: | ||
| conn = self._unservicable_conns.get() | ||
| if conn is None: | ||
| return |
There was a problem hiding this comment.
I think we should call shutdown() here (under Python 3.13+).
There was a problem hiding this comment.
Can you clarify what you mean?
cheroot/server.py
Outdated
| level=logging.ERROR, | ||
| traceback=True, | ||
| ) | ||
| conn.linger = True |
There was a problem hiding this comment.
I was just copying existing code that did that in error handling, but empirically looks like not on Linux at least. Will see what CI does on Windows and macOS.
| request = HTTPRequest(self, conn) | ||
| try: | ||
| request.simple_response('503 Service Unavailable') | ||
| except Exception as ex: |
There was a problem hiding this comment.
Is there a way to make this only intercept narrow exceptions?
There was a problem hiding this comment.
We need a catchall so the thread doesn't die. But I can make more likely exceptions not get logged, at least.
The 503 responses are run in a thread
itamarst
force-pushed
the
503-when-overloaded
branch
from
c532189 to
b460ce4
Compare
|
Failures are due to 3.14 and #747, unrelated to this PR as far as I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ What kind of change does this PR introduce?
❓ What is the current behavior? (You can also link to an open issue here)
When connections can't be handled, the connection is just closed.
❓ What is the new behavior (if this is a feature change)?
A 503 error is returned, as suggested in TODO comment in relevant part of the code.
Since writing to the socket is blocking, this is done in a thread.
📋 Other information:
For some reason OpenStack Ironic needs this apparently, I didn't dig into why.
📋 Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences
This change is