Skip to content

fix(account): MySQL TEXT column default value compatibility (#502) #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenyme merged 1 commit into from
Apr 22, 2026
Merged

fix(account): MySQL TEXT column default value compatibility (#502) #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions app/control/account/backends/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,10 +523,27 @@ async def _ensure_columns(self, conn: Any) -> None:
"""Idempotent ALTER TABLE migrations for columns added after the initial schema."""
existing = await self._table_columns(conn, _TBL_ACCOUNTS)
if "quota_grok_4_3" not in existing:
await conn.exec_driver_sql(
f"ALTER TABLE {_TBL_ACCOUNTS} "
f"ADD COLUMN quota_grok_4_3 TEXT NOT NULL DEFAULT '{{}}'"
)
if self._dialect == "mysql":
# MySQL forbids DEFAULT values on TEXT/BLOB columns;
# add as nullable, backfill, then promote to NOT NULL.
await conn.exec_driver_sql(
f"ALTER TABLE {_TBL_ACCOUNTS} "
f"ADD COLUMN quota_grok_4_3 TEXT"
)
await conn.exec_driver_sql(
f"UPDATE {_TBL_ACCOUNTS} "
f"SET quota_grok_4_3 = '{{}}' "
f"WHERE quota_grok_4_3 IS NULL"
)
await conn.exec_driver_sql(
f"ALTER TABLE {_TBL_ACCOUNTS} "
f"MODIFY COLUMN quota_grok_4_3 TEXT NOT NULL"
)
else:
await conn.exec_driver_sql(
f"ALTER TABLE {_TBL_ACCOUNTS} "
f"ADD COLUMN quota_grok_4_3 TEXT NOT NULL DEFAULT '{{}}'"
)

async def _table_columns(self, conn: Any, table: str) -> set[str]:
if self._dialect == "postgresql":
Expand Down
Loading