Skip to content

VXLAN Support#35

Open
mkp-rh wants to merge 14 commits into
chaudron:masterfrom
mkp-rh:master
Open

VXLAN Support#35
mkp-rh wants to merge 14 commits into
chaudron:masterfrom
mkp-rh:master

Conversation

@mkp-rh

@mkp-rh mkp-rh commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

This patch completes the trex/vxlan support, and adds a pvp test for vxlan.

Furthermore, now ovs_performance.py will pass flake8 checks with "--ignore=E501,E221,W503,W504,E502".

mkp-rh added 4 commits January 4, 2022 10:17
Signed-off-by: Mike Pattrick <mkp@redhat.com>
Signed-off-by: Mike Pattrick <mkp@redhat.com>
--ignore=E501,E221,W503,W504,E502 is now supported

Signed-off-by: Mike Pattrick <mkp@redhat.com>
Signed-off-by: Mike Pattrick <mkp@redhat.com>

@chaudron chaudron left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed I start reviewing in the wrong order ;) Will continue tomorrow in the right order!

Comment thread ovs_performance.py Outdated
Comment thread ovs_performance.py Outdated

@chaudron chaudron left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good, and thanks for doing this as this was on my list for a while ;)

Guess I still have some to go... Can you create a separate pull request for this one so I can apply it right away?

@chaudron

chaudron commented Jan 4, 2022

Copy link
Copy Markdown
Owner

This one looks good, and thanks for doing this as this was on my list for a while ;)

Guess I still have some to go... Can you create a separate pull request for this one so I can apply it right away?

Oops this was for the Flake8 commit, hit the wrong button ;)

@chaudron
chaudron self-requested a review January 4, 2022 15:48
mkp-rh added 2 commits January 4, 2022 12:43
--ignore=E501,E221,W503,W504,E502 is now supported

Signed-off-by: Mike Pattrick <mkp@redhat.com>
Signed-off-by: Mike Pattrick <mkp@redhat.com>
@chaudron

chaudron commented Jan 5, 2022

Copy link
Copy Markdown
Owner

Mike, I merged your flake8 part already, so you might need to update this pull request to only include the specific ones for your changes. You also might want to hold off till later as I'm planning to do some more flake fixes today which might mess up some of your changes :(

Comment thread ovs_performance.py Outdated
Comment thread traffic_generator_trex.py
Comment thread traffic_generator_trex.py Outdated
Comment thread traffic_generator_trex.py
Comment thread traffic_generator_trex.py Outdated
Comment thread traffic_generator_trex.py Outdated
Comment thread traffic_generator_trex.py
Comment thread traffic_generator_trex.py Outdated
Comment thread traffic_generator_trex.py Outdated
Comment thread ovs_performance.py Outdated
@chaudron

chaudron commented Jan 6, 2022

Copy link
Copy Markdown
Owner

I've completed the initial review. I'll try to test it out on the next iteration of the set when I have some documentation ;)

@chaudron chaudron self-assigned this Jan 6, 2022
mkp-rh added 8 commits January 7, 2022 09:20
Signed-off-by: Mike Pattrick <mkp@redhat.com>
Signed-off-by: Mike Pattrick <mkp@redhat.com>
Signed-off-by: Mike Pattrick <mkp@redhat.com>
Signed-off-by: Mike Pattrick <mkp@redhat.com>
Signed-off-by: Mike Pattrick <mkp@redhat.com>
Signed-off-by: Mike Pattrick <mkp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants