wrap: don't write breakpoint past the line limit#866
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
Closes charmbracelet#785. When a breakpoint character was encountered, the current word and the breakpoint were always appended to the current line, even if doing so would push past the wrap limit. Glamour saw this as charmbracelet#505. If the combined width would overflow, break the line first so the word and its trailing breakpoint wrap together onto the next line. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #785, and the glamour case that's tracking it (charmbracelet/glamour#505).
When the wrapper hit a breakpoint character, it appended the buffered word plus the breakpoint to the current line unconditionally, even if doing so pushed past the wrap limit. If the combined width would overflow, break the line first so the word and its trailing breakpoint wrap together onto the next line.
Test case added:
breakpoint_overflow.