feat: add alphabetical, commit and config order to ls and tui#212
Open
salasberryfin wants to merge 1 commit intocharmbracelet:mainfrom
Open
feat: add alphabetical, commit and config order to ls and tui#212salasberryfin wants to merge 1 commit intocharmbracelet:mainfrom
salasberryfin wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
Author
|
I don't find a simple way to add a test that validates the commit date order. I welcome any suggestions. Other than that I think it is ready to review. |
Author
|
Any maintainer can take a look at this? |
Contributor
|
Thanks @salasberryfin for taking a look at this. The idea I had in mind was like pinning repositories in GitHub. So the repos in Let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still WIP.
Related to #193.
The ideas behind these changes are:
config.yamlto set the type of order for the repositories:alphabetical,commitorconfig.sortedto theRepoSourcestruct.SortonRepoSource.Sortwhen the configuration is loaded.lsand TUI.config.yaml. The remaining repositories that don't appear in the config file are appended at the end with no specific order.commit, the repositories with most recent commits are shown first.After giving it some thought, this is what felt sensible to me. Is it aligned with the original idea?
Thanks in advance for the feedback.