fix(style): preserve word separation when Inline replaces newlines - #733
Open
beltagyy wants to merge 1 commit into
Open
fix(style): preserve word separation when Inline replaces newlines#733beltagyy wants to merge 1 commit into
beltagyy wants to merge 1 commit into
Conversation
When Inline mode encounters multi-line strings it strips \n characters
but concatenates the last word of one line with the first word of the
next. Replace newlines with a single space so that
style.Render("hello\nworld")
produces "hello world" instead of "helloworld".
Fixes charmbracelet#116
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Inline mode encounters multi-line strings it strips \n characters but concatenates the last word of one line with the first word of the next.
This change replaces newlines with a single space so that
produces "hello world" instead of "helloworld".
Adds a focused test for the new behaviour (hello\nworld, CRLF, and single-word inputs).
Fixes #116