Fix order of calling w.Close in Wrap - #689
Open
neomantra wants to merge 1 commit into
Open
Conversation
…link` the `WrapWriter` emits on close is included in the returned string. Using `defer w.Close()` here would write the closing resets to buf *after* `buf.String()` snapshots it, dropping them from the return value and leaving callers with output that ends in a dangling SGR/OSC8 — which in turn trips a use-after-close panic in glamour's `IndentWriter.Close` write-cascade. Signed-off-by: Evan Wies <evan@neomantra.net>
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I surfaced this testing Crush; chains with a Glamour issue. LLM-assisted, but I read and understood the patch.
CloseBEFORE readingbufso the trailingResetStyle / ResetHyperlinkthat the
WrapWriteremits on close is included in the returned string.Using
defer w.Close()here would write the closing resets to buf afterbuf.String()snapshots it, dropping them from the return value and leaving callers with output that ends in a dangling SGR/OSC8 — which in turn trips a use-after-close panic in glamour'sIndentWriter.Closewrite-cascade.CONTRIBUTING.md.