fix: downsample insertAbove content to the color profile#1714
Open
truffle-dev wants to merge 1 commit into
Open
fix: downsample insertAbove content to the color profile#1714truffle-dev wants to merge 1 commit into
truffle-dev wants to merge 1 commit into
Conversation
Content delivered through tea.Println / Program.Println was written to the terminal verbatim, bypassing the color-profile downsampling that view content gets via the screen renderer. Under NO_COLOR or a low-color profile, the live view obeyed the profile while every line committed to scrollback kept its original colors. Route the queued content through a colorprofile.Writer before composing the insert sequence, so message colors degrade the same way view colors do. The cursor movements composed around the content are untouched. Fixes charmbracelet#1709
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Content delivered through
tea.Println/Program.Printlnreached the terminal verbatim, bypassing the color-profile downsampling that view content gets through the screen renderer. UnderNO_COLOR(or a 16-color/ascii profile) the live view obeyed the profile while every line committed to scrollback kept its original colors.This routes the queued content through a
colorprofile.WriterininsertAbovebefore the insert sequence is composed, so message colors degrade the same way view colors do. The cursor movements composed around the content are untouched, and theTrueColorcase skips the conversion entirely since the writer is a passthrough there.main.CONTRIBUTING.md.