Skip to content

fix: suppress View output when executing a subprocess #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blackwell-systems wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: suppress View output when executing a subprocess #1687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,14 @@ func (c *osExecCommand) SetStderr(w io.Writer) {

// exec runs an ExecCommand and delivers the results to the program as a Msg.
func (p *Program) exec(c ExecCommand, fn ExecCallback) {
// Clear the current view before releasing the terminal so the renderer's
// final flush doesn't write the last View() output to stdout. Without
// this, the view content leaks to the terminal and persists after the
// subprocess exits.
if p.renderer != nil {
p.renderer.render(View{})
}

if err := p.releaseTerminal(false); err != nil {
// If we can't release input, abort.
if fn != nil {
Expand Down