Skip to content

Fedora performance fixes#8

Merged
charleschetty merged 1 commit intocharleschetty:mainfrom
Sisyphus1813:fedora-performance-fixes
Jul 10, 2025
Merged

Fedora performance fixes#8
charleschetty merged 1 commit intocharleschetty:mainfrom
Sisyphus1813:fedora-performance-fixes

Conversation

@Sisyphus1813
Copy link
Copy Markdown
Contributor

  • This update fixes performance issues on Fedora systems that was caused by Pull Request 6.
  • The performance issues revolved around using rust's Commands which are (comparatively) slow as they rely on CLI.
  • This has been replaced by the rpm-pkg-count crate, which has improved performance on the Fedora kernel significantly. However, this does require installation of the rpm-devel package on Fedora systems in order to display installed package count, otherwise it will return an empty value, but will not cause runtime or compile issues.
  • Updated README to reflect Fedora support and the other changes.

- This update fixes performance issues on Fedora systems that was caused by Pull Request 6.
- The performance issues revolved around using rust's Commands which are (comparatively) slow as they rely on CLI.
- This has been replaced by the rpm-pkg-count crate, which has improved performance on the Fedora kernel significantly. However, this does require installation of the rpm-devel package on Fedora systems in order to display installed package count, otherwise it will return an empty value, but will not cause runtime or compile issues.
- Updated README to reflect Fedora support and the other changes.
@charleschetty
Copy link
Copy Markdown
Owner

Thanks for your PR,

Seems that there is no suitable method to quickly count RPM packages without introducing external libraries. I checked the fastfetch, they also use librpm....

@charleschetty charleschetty merged commit c4bf917 into charleschetty:main Jul 10, 2025
2 checks passed
@charleschetty
Copy link
Copy Markdown
Owner

  • This has been replaced by the rpm-pkg-count crate, which has improved performance on the Fedora kernel significantly. However, this does require installation of the rpm-devel package on Fedora systems in order to display installed package count, otherwise it will return an empty value, but will not cause runtime or compile issues.

I think the cargo features mechanism may help ()

@Sisyphus1813
Copy link
Copy Markdown
Contributor Author

Sisyphus1813 commented Jul 10, 2025

Cool! I will look more into this also.

Later down the line we could possibly rewrite the cargo package itself such that we aren't introducing third party dependencies. But yes, right now I also don't see a reason to reinvent the wheel. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants