Fedora performance fixes#8
Merged
charleschetty merged 1 commit intocharleschetty:mainfrom Jul 10, 2025
Sisyphus1813:fedora-performance-fixes
Merged
Fedora performance fixes#8charleschetty merged 1 commit intocharleschetty:mainfrom Sisyphus1813:fedora-performance-fixes
charleschetty merged 1 commit intocharleschetty:mainfrom
Sisyphus1813:fedora-performance-fixes
Conversation
Contributor
Sisyphus1813
commented
Jul 10, 2025
- This update fixes performance issues on Fedora systems that was caused by Pull Request 6.
- The performance issues revolved around using rust's Commands which are (comparatively) slow as they rely on CLI.
- This has been replaced by the rpm-pkg-count crate, which has improved performance on the Fedora kernel significantly. However, this does require installation of the rpm-devel package on Fedora systems in order to display installed package count, otherwise it will return an empty value, but will not cause runtime or compile issues.
- Updated README to reflect Fedora support and the other changes.
- This update fixes performance issues on Fedora systems that was caused by Pull Request 6. - The performance issues revolved around using rust's Commands which are (comparatively) slow as they rely on CLI. - This has been replaced by the rpm-pkg-count crate, which has improved performance on the Fedora kernel significantly. However, this does require installation of the rpm-devel package on Fedora systems in order to display installed package count, otherwise it will return an empty value, but will not cause runtime or compile issues. - Updated README to reflect Fedora support and the other changes.
Owner
|
Thanks for your PR, Seems that there is no suitable method to quickly count RPM packages without introducing external libraries. I checked the fastfetch, they also use librpm.... |
Owner
I think the cargo features mechanism may help () |
Contributor
Author
|
Cool! I will look more into this also. Later down the line we could possibly rewrite the cargo package itself such that we aren't introducing third party dependencies. But yes, right now I also don't see a reason to reinvent the wheel. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.