Skip to content

Conversation

@princesust
Copy link

Now we don't need to put slack fonts in public/fonts directory
We can pass slack counter style properties like below

const styles = {
  addStyle: {
    paddingLeft: '4px',
    opacity: '1',
  },
};

<SlackCounter styles={styles} />

This styles will be merged with default addStyle

borhan.uddiin and others added 2 commits August 16, 2022 01:25
@charkour
Copy link
Owner

Hey @princesust,

Thanks for the PR, I can take a look at it in a couple of hours after I'm done with my work day.

Thank you for taking the time to open the PR.

borhan.uddiin and others added 2 commits August 16, 2022 02:20
@princesust
Copy link
Author

princesust commented Aug 15, 2022

Hi @charkour,
I test it directly from local and it was working perfectly. Later when I put build command it showing some errors. May be it's tsdx or typescript related issue. I am not familiar with tsdx and typescript. Maybe you can fix it. I removed fonts from example folder and run it and it's working.

@charkour charkour self-assigned this Aug 16, 2022
@charkour charkour added the enhancement New feature or request label Aug 16, 2022
@charkour charkour self-requested a review August 30, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants