Improve/add support for multiple safety controllers #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, it is possible to pass different GPIOs to use via command line arguments. This is handy during development, but in final products, it makes the resulting command lines long and unreadable when the safety controller is not connected on the compiled-in default interface. Also in scripts, this would not be much better. So let's allow to specify the GPIO stuff via environment as already done for the UART used. Signed-off-by: Michael Heimpold <[email protected]>
On upcoming products like e.g. Charge Control V, we have multiple safety controllers. This also means to have multiple instances to be checked and updated. Here we can use the instances feature by systemd, bundled with using a specific environment per interface and limiting the instances by matching the Device Tree compatible string. Signed-off-by: Michael Heimpold <[email protected]>
Signed-off-by: Michael Heimpold <[email protected]>
mhei
requested review from
Erik827,
FaHaGit,
barsnick,
lategoodbye,
martinlukas84 and
t-mon
lategoodbye
approved these changes
Jan 14, 2026
Erik827
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, support for multiple instances of the safety controller on one platform is improved.
The main goal is to check on several UARTs whether a firmware update is required.
A corresponding small change in our meta-chargebyte-distro layer will be necessary, to enable
all required instances on our products.