Conversation
|
Generally looks good. Left a few minor comments. I'll be blocked on merging this until the copyright paperwork is signed. |
|
Did the copyright paperwork get signed? I saw the request go out but did not see a conclusion. |
|
I have send the form to assign@gnu.org but did not get a repose yet. is there anything i can do here to speed up the process? |
|
I'm not sure. I would do the usual things (check your spam folder, reach out again, etc.). I believe this part is all manual, so reaching out on other email threads like the existing one on emacs-devel may help as well. |
|
Craig Topham has now send me the signed document. So we should be good to go. |
chaosemer
left a comment
chaosemer
left a comment
There was a problem hiding this comment.
Small changes requested. Otherwise, this looks good. Thank you!
| "<mode-line> <triple-down-mouse-1>" #'window-tool-bar--ignore | ||
| "<mode-line> <down-mouse-2>" #'window-tool-bar--ignore | ||
| "<mode-line> <double-down-mouse-2>" #'window-tool-bar--ignore | ||
| "<mode-line> <triple-down-mouse-2>" #'window-tool-bar--ignore) |
There was a problem hiding this comment.
Are you sure this is needed? This is intended to be handled by just a few lines below:
(keymap-set window-tool-bar--button-keymap
"<mode-line>"
(keymap-lookup window-tool-bar--button-keymap "<tab-line>"))
| "<tab-line> <down-mouse-2>" #'window-tool-bar--ignore | ||
| "<tab-line> <double-down-mouse-2>" #'window-tool-bar--ignore | ||
| "<tab-line> <triple-down-mouse-2>" #'window-tool-bar--ignore) | ||
| "<tab-line> <triple-down-mouse-2>" #'window-tool-bar--ignore |
There was a problem hiding this comment.
This makes sense, looks like a gap in the logic.
| (let ((list (append | ||
| '(mouse-movement pinch | ||
| wheel-down wheel-up wheel-left wheel-right) | ||
| wheel-down wheel-up wheel-left wheel-right) |
There was a problem hiding this comment.
Please revert this line -- it's not proper indentation for Emacs data lists.
2 participants
Add missing bindings to mode line