Open
Conversation
Author
|
Note: This doesn't expose enough information because socket address is hidden in the implementation in the |
Author
|
I have made changes to I still have to move the moment that we allow setting the |
9a737fd to
c5eed90
Compare
ReinierMaas
commented
Dec 3, 2025
This allows the caller to create a structure that is available during the `open_socket` evaluation
fe81c61 to
1ef6183
Compare
SanderHageman
approved these changes
Dec 5, 2025
SanderHageman
left a comment
There was a problem hiding this comment.
LGTM! the DefaultOpenSocketHandler looks a bit cursed but I can't immediately think of a better implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XRef: #1
Alternative implementation that makes it possible to use a custom
open_socketfunction.