Go-based answers file generator #56
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdolitsky
commented
Jun 16, 2025
Comment on lines
+259
to
+276
| for _, vuln := range testCase.OptionalVulnerabilities { | ||
| isOptional := true | ||
|
|
||
| // Check if any ID in this vulnerability pair is in the OSV feed | ||
| for _, id := range vuln { | ||
| if osvVulns[id] { | ||
| // If it's in the OSV feed with fixed versions, it's not optional | ||
| isOptional = false | ||
| break | ||
| } | ||
| } | ||
|
|
||
| if isOptional { | ||
| stillOptional = append(stillOptional, vuln) | ||
| } else { | ||
| notOptional = append(notOptional, vuln) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is core of the optional vs. non-optional logic
Signed-off-by: Josh Dolitsky <[email protected]>
jdolitsky
force-pushed
the
go-based-answers-gen
branch
from
75f6766 to
98253ec
Compare
cpanato
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.