This repository was archived by the owner on Nov 30, 2018. It is now read-only.
Parse more_from_developer only when corresponding div exists#79
Open
lightalloy wants to merge 2 commits intochadrem:masterfrom
Open
Parse more_from_developer only when corresponding div exists#79lightalloy wants to merge 2 commits intochadrem:masterfrom
lightalloy wants to merge 2 commits intochadrem:masterfrom
Conversation
Contributor
Author
|
However, fetching "similar apps" and "more from the developer" apps is still very brittle and needs to be reworked. |
|
Any timeline of when this will be fixed? |
Owner
|
@mayaah I’m the original author of this project but I don’t maintain it anymore. I’m currently looking for people who want to take over the project. Please contact me if you are interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional check if more_from_developer exists (prevent from failing with
undefined method 'children' for nil:NilClassCurrently, more_from_developer is fetched only from pages like WeatherPro and not like My Little Pony Celebration
I've also updated the test data