Skip to content

ci: Own tool provisioning and remove the agenthome installer - #89

Merged
cgwalters-bot merged 1 commit into
cgwalters-forge:mainfrom
cgwalters-bot:dispatch/implement/agent-run-43559019100
Nov 14, 2026
Merged

cgwalters-bot merged 1 commit into
cgwalters-forge:mainfrom
cgwalters-bot:dispatch/implement/agent-run-43559019100

Conversation

@cgwalters-bot

Copy link
Copy Markdown
Collaborator

Executive summary

Move Check's tool provisioning into ordinary pinned, checksum-verified, bounded job-local setup and remove the Rust installer and its CLI/Justfile interfaces. Keep offline eval and configuration behavior intact.

Part of #76

The refreshed caller audit is in README.md: no active external installer dependency was found in current tracker, agentic-job or agent-board default branches; deployed and other-branch callers remain unverified. No cross-repository changes or dispatch installation were made. Eval relocation and final Cargo/tracker package removal remain later slices; PR #87 and its human-approval hold are untouched. The audit is durable in README.md; this run cannot update the issue body's Findings link.

Verified: just check, reference/dependency audit, and controlled cold-cache network provisioning with all version/navigation smoke checks and checksum-mismatch rejection before extraction. GitHub-hosted CI itself has not run here; no paid evals or hosted role probes ran.

Review: one adversarial pass, no blockers; its download-size cap, test-only tempfile and stale constraint-comment findings were addressed afterward and rechecked; no follow-ups remain.

Generated by dispatch · ◷

## Executive summary

Move Check's tool provisioning into ordinary pinned, checksum-verified, bounded job-local setup and remove the Rust installer and its CLI/Justfile interfaces. Keep offline eval and configuration behavior intact.

Part of cgwalters-forge#76

The refreshed caller audit is in README.md: no active external installer dependency was found in current tracker, agentic-job or agent-board default branches; deployed and other-branch callers remain unverified. No cross-repository changes or dispatch installation were made. Eval relocation and final Cargo/tracker package removal remain later slices; PR cgwalters-forge#87 and its human-approval hold are untouched. The audit is durable in README.md; this run cannot update the issue body's Findings link.

Verified: just check, reference/dependency audit, and controlled cold-cache network provisioning with all version/navigation smoke checks and checksum-mismatch rejection before extraction. GitHub-hosted CI itself has not run here; no paid evals or hosted role probes ran.

Review: one adversarial pass, no blockers; its download-size cap, test-only tempfile and stale constraint-comment findings were addressed afterward and rechecked; no follow-ups remain.

Assisted-by: https://github.com/cgwalters/cgwalters#llms

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERDICT: APPROVE — no concrete blocker found.

Reviewed admitted head a5a873b40d91e8e067610a210dde1077f11f35c2 against origin/main, merge-base 4e68032821d38fa0f49601fd4882c68f4afd3bbe.

Follow-ups

  • important — README.md:46–67, .github/workflows/check.yml:23–51: real-caller preview evidence is missing. The caller audit identifies revisions but leaves deployed callers unverified; the PR's cold-cache provisioning claim has no inspectable command log/artifact. Please provide the caller/configuration, exact command and reviewed revision, and a disposable/no-apply run artifact showing provisioning and navigation results. This review does not treat that claim as a successful preview.

Bounds assessed

The worst provisioning outcome is execution of upstream tool/wheel code on the Check runner. Release URLs, versions and hashes match the removed manifest, and checksums run before extraction/execution. The Python constraints and upload cutoff are retained with --no-build; historical PyPI wheel bytes remain an explicitly documented trust dependency, not hash-verified artifacts. Unchanged push/pull_request triggers and contents: read permissions do not introduce a privileged target-event path. The job-local prefix, download caps, step deadlines and job timeout bound installation; the changed standing rules retain the no-agent-install fallback. Cargo changes only remove dependencies/move tempfile to dev-dependencies; no added/bumped package, registry change or new install script was found. No base CODEOWNERS file was found.

Tried

  • Read the complete diff and surrounding workflow, CLI, constraints and documentation; audited remaining installer references.
  • cargo run -- --help — exit 127: Cargo is unavailable, so CLI output/JSON ergonomics could not be exercised.
  • curl --fail --location --silent --show-error --connect-timeout 15 --max-time 60 --max-filesize 134217728 --output /tmp/opencode/review-89-uv.tar.gz https://github.com/astral-sh/uv/releases/download/0.13.1/uv-x86_64-unknown-linux-gnu.tar.gz — exit 23, local output-write failure. This was a targeted attempt to check the new exact uv version assertion; checksum verification, extraction and execution were not reached.
  • No suites, formatters, linters or CI results were used. No repository changes or live caller writes were made. Durable findings/issue-body updates are outside this run's authorized outputs.

Generated-by: https://github.com/cgwalters/#llms

Generated by review for #89 at a5a873b

@cgwalters-bot
cgwalters-bot merged commit ce75a39 into cgwalters-forge:main Nov 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant