CFE-3429: Use current process ID to investigate proc filesystem to workaround in-container non-root owned symlinks (3.24) #5780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
craigcomstock
commented
Apr 23, 2025
craigcomstock
commented
- Use current process ID to investigate proc filesystem to workaround in-container non-root owned symlinks
- Added error message when netstat file is not found during UNIX interface discovery.
- Move GetRelocatedProcdirRoot() from libntech and add GetProcdirPid()
- Added env var pid override in proc-net acceptance test To align with change to reading /proc//...
- bump libntech to master
…n-container non-root owned symlinks
Note man 5 proc mentions how the symlinks work:
/proc/self
When a process accesses this magic symbolic link, it resolves to the process's own /proc/pid directory.
and also:
With the advent of network namespaces, various information relating to the network stack is virtualized (see net‐
work_namespaces(7)). Thus, since Linux 2.6.25, /proc/net is a symbolic link to the directory /proc/self/net, which
contains the same files and directories as listed below. However, these files and directories now expose informa‐
tion for the network namespace of which the process is a member.
So this change seems like a good workaround for linux systems and CFEngine's requirement that symlinks be owned by the running pid.
Ticket: CFE-3429
Changelog: title
Signed-off-by: Craig Comstock <[email protected]>
(cherry picked from commit 031972b)
…ace discovery. Ticket: CFE-3429 Changelog: none (cherry picked from commit 8441e84)
These have checks for environment variables to override to support testing. Ticket: CFE-3429 Changelog: none (cherry picked from commit 628055f)
To align with change to reading /proc/<pid>/... Ticket: CFE-3429 Changelog: none (cherry picked from commit 8470d79)
|
Thanks for submitting a pull request! Maybe @larsewi can review this? |
|
Marking this PR as stale due to inactivity; it will be closed in 7 days. |
|
Closing PR due to inactivity. Feel free to open a new PR if necessary. |
|
@craigcomstock , looks like this one auto-closed, re-opening. |
nickanderson
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.