Skip to content

Conversation

@erikgb
Copy link
Member

@erikgb erikgb commented Nov 16, 2025

This is a leftover after #1842. I left this out because I wanted to use the Flux OCIRepository source resource instead of the more traditional HelmRepository. But it seems like the flux CLI doesn't currently support creating Helm OCIRepository resources as described in https://fluxcd.io/flux/components/helm/helmreleases/#recommended-settings.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2025
@netlify
Copy link

netlify bot commented Nov 16, 2025

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 49f7d15
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/6919abf228b9160008990e29
😎 Deploy Preview https://deploy-preview-1846--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I know nothing about flux but this seems obvious to do, so I'll approve 😁 Thank you!

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2025
@cert-manager-prow cert-manager-prow bot merged commit 731d840 into cert-manager:master Nov 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants