Skip to content

Conversation

@inteon
Copy link
Member

@inteon inteon commented Sep 7, 2023

  • moves csi-driver & csi-driver-spiffe to the usages section
  • moves istio-csr to the usages section
  • renames the menu items
  • moves the CertificateRequest item from the concepts section to the usages section

TODO:
merge the Certificate item from the concepts section with the Certificate item in the usages section

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Sep 7, 2023
@jetstack-bot
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2023
@jetstack-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from inteon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inteon inteon deleted the branch cert-manager:move_project_items September 7, 2023 13:22
@inteon inteon closed this Sep 7, 2023
@inteon inteon deleted the move_project_items branch September 7, 2023 13:24
@inteon inteon restored the move_project_items branch September 7, 2023 13:24
@inteon
Copy link
Member Author

inteon commented Sep 7, 2023

This PR was incorrectly auto-closed due to me removing the branch on this repo (not my fork) with the same name.

It should not have been closed because this PR's origin is my fork and not a branch on this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants