Skip to content

Conversation

@SgtCoDFish
Copy link
Member

Also allows specifying the branch name from which cmrel should be built, for easier testing

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Feb 28, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sgtcodfish. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 28, 2025
@SgtCoDFish SgtCoDFish marked this pull request as draft March 6, 2025 17:29
@cert-manager-prow cert-manager-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2025
@SgtCoDFish
Copy link
Member Author

Draft because this has turned out to be harder than expected!

@SgtCoDFish
Copy link
Member Author

We've documented that this should be done manually going forwards. Leaving this here because it's maybe helpful for fully automating things, but no urgent need right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants