Skip to content

Conversation

@erikgb
Copy link
Member

@erikgb erikgb commented Nov 2, 2025

This new analyzer generates a lot of new lint errors across our projects, and I think we need some time to discuss how to move forward with this.

See cert-manager/approver-policy#739 (comment) for context.

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Nov 2, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wallrj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@erikgb erikgb requested review from Copilot and inteon November 2, 2025 19:30
@cert-manager-prow cert-manager-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configuration to disable the omitzero check in the modernize linter for Go code. The change is temporary, with a TODO comment indicating that this check should be enabled after the team discusses migration strategy from omitempty to omitzero.

  • Added modernize settings section with omitzero check disabled
  • Included a TODO comment explaining the reason for disabling and future action needed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@inteon
Copy link
Member

inteon commented Nov 3, 2025

@erikgb I think the linter is very useful and we can fix the linter without making breaking changes (eg. dropping omitempty instead of replacing it with omitzero). WDYT?

@erikgb
Copy link
Member Author

erikgb commented Nov 3, 2025

@erikgb I think the linter is very useful and we can fix the linter without making breaking changes (eg. dropping omitempty instead of replacing it with omitzero). WDYT?

Ok, let's try. 👍

@erikgb erikgb closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants