-
Notifications
You must be signed in to change notification settings - Fork 16
Make Renovate ungroup major/digest upgrades #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Erik Godding Boye <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the Renovate configuration to adjust how updates for custom regex-managed dependencies are handled. The changes remove the manual approval requirement for major and digest updates while ensuring these updates are not grouped with other dependencies.
- Adds explicit
groupName: nullto prevent grouping major/digest updates with the "Tools" group - Removes
dependencyDashboardApproval: trueto allow automatic processing of major and digest updates
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| groupName: null, | ||
| matchManagers: [ | ||
| 'custom.regex', | ||
| ], | ||
| matchUpdateTypes: [ | ||
| 'major', | ||
| 'digest', | ||
| ], | ||
| dependencyDashboardApproval: true, | ||
| }, |
Copilot
AI
Nov 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package rule conflicts with the 'Tools' group rule (lines 44-55) which also matches 'custom.regex' manager. The 'Tools' rule will group all custom.regex updates together, but this rule attempts to exclude major/digest updates from grouping. Consider adding excludeUpdateTypes: ['major', 'digest'] to the 'Tools' rule to make the intent clearer and avoid relying on rule ordering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it would be clearer to do it that way, but then I have to repeat the post-upgrade task.
Reconfigure PR ResultsThis is a reconfigure PR comment to help you understand and re-configure your renovate bot settings. If this Reconfigure PR were to be merged, we'd expect to see the following outcome: Detected Package Files
Configuration SummaryBased on the default config's presets, Renovate will:
What to ExpectWith your current configuration, Renovate will create 3 Pull Requests: chore(deps): update renovate/renovate docker tag to v41.168.3
chore(deps): update dependency protocolbuffers/protobuf to v33
chore(deps): update module github.com/sigstore/cosign/v2 to v3
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ThatsMrTalbot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looking at #447, I want to merge the Proto upgrade, but probably wait for the Cosign major upgrade. This PR should make Renovate split that PR into two.