-
Notifications
You must be signed in to change notification settings - Fork 35
Migrate from legacy Helm to OCI #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the project from using the legacy HTTPS Helm chart repository to OCI-based Helm charts hosted on quay.io, aligning with modern Helm practices and the changes made in the approver-policy project.
Key Changes:
- Updated Helm installation commands to use OCI format (
oci://quay.io/jetstack/charts/) - Simplified release process documentation by removing the wait step for chart propagation
- Updated artifact documentation to clarify OCI as primary distribution with legacy repo as secondary
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| make/test-e2e.mk | Updated e2e test setup to install cert-manager using OCI chart format, removing the legacy --repo flag and correcting command structure |
| RELEASE.md | Updated release documentation to reflect OCI chart publishing as primary method, clarified legacy HTTPS repo as secondary with potential delays |
| README.md | Simplified installation instructions to use OCI chart directly, removing the need for helm repo add command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Erik Godding Boye <[email protected]>
This PR mimics the changes done in cert-manager/approver-policy#748 to update our release process documentation. In addition, I have also migrated other references to the legacy https Helm chart repo to OCI.