Skip to content

Conversation

@erikgb
Copy link
Member

@erikgb erikgb commented Nov 16, 2025

This PR mimics the changes done in cert-manager/approver-policy#748 to update our release process documentation. In addition, I have also migrated other references to the legacy https Helm chart repo to OCI.

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Nov 16, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2025
@erikgb erikgb requested a review from Copilot November 16, 2025 11:25
Copilot finished reviewing on behalf of erikgb November 16, 2025 11:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project from using the legacy HTTPS Helm chart repository to OCI-based Helm charts hosted on quay.io, aligning with modern Helm practices and the changes made in the approver-policy project.

Key Changes:

  • Updated Helm installation commands to use OCI format (oci://quay.io/jetstack/charts/)
  • Simplified release process documentation by removing the wait step for chart propagation
  • Updated artifact documentation to clarify OCI as primary distribution with legacy repo as secondary

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
make/test-e2e.mk Updated e2e test setup to install cert-manager using OCI chart format, removing the legacy --repo flag and correcting command structure
RELEASE.md Updated release documentation to reflect OCI chart publishing as primary method, clarified legacy HTTPS repo as secondary with potential delays
README.md Simplified installation instructions to use OCI chart directly, removing the need for helm repo add command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@erikgb erikgb requested a review from Copilot November 16, 2025 11:31
Copilot finished reviewing on behalf of erikgb November 16, 2025 11:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@erikgb erikgb requested a review from Copilot November 16, 2025 11:35
Copilot finished reviewing on behalf of erikgb November 16, 2025 11:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Erik Godding Boye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants