Skip to content

Conversation

@erikgb
Copy link
Member

@erikgb erikgb commented Nov 16, 2025

This PR mimics the changes done in cert-manager/approver-policy#748 to update our release process documentation. In addition, I have also migrated other references to the legacy https Helm chart repo to OCI. And also removed the pre-release step to check for new versions of upstream CSI images as this is done "continously" by Renovate now.

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Nov 16, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@erikgb erikgb requested a review from Copilot November 16, 2025 11:59
@cert-manager-prow cert-manager-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 16, 2025
Copilot finished reviewing on behalf of erikgb November 16, 2025 12:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the cert-manager Helm chart references from the legacy HTTPS repository (https://charts.jetstack.io) to the OCI registry (oci://quay.io/jetstack/charts/cert-manager), aligning with modern Helm practices and the changes made in the approver-policy repository.

Key changes:

  • Updated Helm installation command to use OCI registry format with proper argument ordering
  • Removed manual pre-release checks for upstream CSI images (now automated via Renovate)
  • Clarified that the legacy HTTP repository is maintained by Venafi and may experience delays

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
make/test-e2e.mk Migrated cert-manager Helm installation from legacy HTTP repo to OCI registry, updated version variable reference, and corrected command syntax for OCI charts
RELEASE.md Updated release documentation to reflect OCI-first approach, removed obsolete manual image update checks, clarified legacy repo status, and fixed minor grammar/spelling issues

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Erik Godding Boye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant