-
Notifications
You must be signed in to change notification settings - Fork 97
Update e2e tests to be partitional #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,4 @@ metadata: | |
| name: demo-test-root-ca | ||
| spec: | ||
| arn: $CA_ARN | ||
| region: us-east-1 | ||
| region: $AWS_REGION | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,13 +5,13 @@ go 1.23.0 | |
| toolchain go1.24.2 | ||
|
|
||
| require ( | ||
| github.com/aws/aws-sdk-go-v2 v1.36.3 | ||
| github.com/aws/aws-sdk-go-v2/config v1.29.14 | ||
| github.com/aws/aws-sdk-go-v2/credentials v1.17.67 | ||
| github.com/aws/aws-sdk-go-v2/service/acmpca v1.40.2 | ||
| github.com/aws/aws-sdk-go-v2/service/iam v1.41.1 | ||
| github.com/aws/aws-sdk-go-v2/service/ram v1.30.3 | ||
| github.com/aws/aws-sdk-go-v2/service/sts v1.33.19 | ||
| github.com/aws/aws-sdk-go-v2 v1.39.3 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's this update get us?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. adds new region endpoints |
||
| github.com/aws/aws-sdk-go-v2/config v1.31.13 | ||
| github.com/aws/aws-sdk-go-v2/credentials v1.18.17 | ||
| github.com/aws/aws-sdk-go-v2/service/acmpca v1.44.5 | ||
| github.com/aws/aws-sdk-go-v2/service/iam v1.47.8 | ||
| github.com/aws/aws-sdk-go-v2/service/ram v1.34.7 | ||
| github.com/aws/aws-sdk-go-v2/service/sts v1.38.7 | ||
| github.com/cert-manager/cert-manager v1.17.1 | ||
| github.com/cucumber/godog v0.15.0 | ||
| github.com/go-logr/logr v1.4.2 | ||
|
|
@@ -26,15 +26,15 @@ require ( | |
|
|
||
| require ( | ||
| github.com/Azure/go-ntlmssp v0.0.0-20221128193559-754e69321358 // indirect | ||
| github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.30 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.34 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.34 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/ini v1.8.3 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.12.3 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.12.15 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/sso v1.25.3 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/ssooidc v1.30.1 // indirect | ||
| github.com/aws/smithy-go v1.22.2 // indirect | ||
| github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.18.10 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.10 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.10 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/ini v1.8.4 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.2 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.10 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/sso v1.29.7 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/ssooidc v1.35.2 // indirect | ||
| github.com/aws/smithy-go v1.23.1 // indirect | ||
| github.com/beorn7/perks v1.0.1 // indirect | ||
| github.com/blang/semver/v4 v4.0.0 // indirect | ||
| github.com/cespare/xxhash/v2 v2.3.0 // indirect | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of making a call to STS to obtain an ARN to parse, you can just parse the CA Arn, since you have that already at this point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I was initially going to do that since that's what we do in the issuer. But, it felt weird to determine the partition from test resources that could change in the future. So this was my way of removing that overhead. I do think we should probably just do this once at the beginning tho and store it in the test context