Update on_release.yml workflow to push to staging ECR repo #373
Conversation
.github/workflows/on-release.yml
Outdated
| - name: Login to Staging ECR | ||
| uses: docker/login-action@v1 | ||
| with: | ||
| registry: 105154636954.dkr.ecr.us-east-1.amazonaws.com |
There was a problem hiding this comment.
Did you mean to use the env variable here?
There was a problem hiding this comment.
I didn't realize that these were the same value, good catch. Thinking back, I think REGISTRY makes more sense than REPO for the env variable names, since these are the registries that contain the repositories.
hanleyyin
force-pushed
the
update_on_release_pr
branch
from
bd0996d to
98f90c6
Compare
| tags: | | ||
| ${{ env.TAG_BASE }}:${{steps.tag.outputs.tag}}-amd64 | ||
| push: true | ||
| - name: Build and push manifest list |
There was a problem hiding this comment.
Why does this need to be a separate step now?
There was a problem hiding this comment.
These all need to be a separate step because to my knowledge, there's no other way to tag the individual architectures in addition to the manifest list.
Images must be pushed to your repository before you create the Docker manifest.
https://docs.aws.amazon.com/AmazonECR/latest/userguide/docker-push-multi-architecture-image.html (this doc link uses docker manifest instead of docker buildx but the same applies)
This also updates the docker/build-push-action to v6, as v2 does not support the provenance option Signed-off-by: HanleyYin <[email protected]>
hanleyyin
force-pushed
the
update_on_release_pr
branch
from
98f90c6 to
770442c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
This also updates the docker/build-push-action to v6, as v2 does not support the provenance option