included user input for missing vars, disabling passwordAuth and enab…#9
Open
17Halbe wants to merge 1 commit intocentic9:masterfrom
Open
included user input for missing vars, disabling passwordAuth and enab…#917Halbe wants to merge 1 commit intocentic9:masterfrom
17Halbe wants to merge 1 commit intocentic9:masterfrom
Conversation
…ling pubkeyAuth on host, and much more
Owner
|
Thanks for the proposed changes. I will merge at least some of it when I find some time to take a closer look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I changed the script to my liking and thought you might be interested. I removed the necessity to use commandline options and inserted user input demands for the not provided (and neccessary) options.
Additionally added the option to modify the sshd_config file on the host to disallow passwordAuthentication and allow PubkeyAuthentication if desired. It also checks if those config changes would be able to be made due to permission restrictions.
It furthermore tries to get the currently used sshd_config file (
ps aux | grep ...)Some documentation changed and the information about a daemon reload was added additionally with a final login check.
Hope that was all and understandable. ;) Thanks for your work and sorry for the hasty PR, I'm in a hurry!