CrontabSchedule day_of_week help text to say that sunday is 0, not 7 #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the help text documentation for the CrontabSchedule model's day_of_week field to accurately reflect that Sunday is only represented as 0, not both 0 and 7 as previously documented.
- Updates help text to remove the misleading "or 7" reference for Sunday
- Includes a Django migration to apply the help text change to the database schema
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| django_celery_beat/models.py | Updates the day_of_week field help text to remove "or 7" for Sunday |
| django_celery_beat/migrations/0020_alter_crontabschedule_day_of_week.py | Django migration to apply the help text change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR updates the CrontabSchedule day_of_week help text to says that sunday is 0, not 0 and 7.
Seems like this confused many users (including me 😅).
I took the easy path of just updating the doc to reflect the current behavior, but the alternative fix would be to actually support 7 as documented.
Fixes #892 #806