feat(scrollbar): add hover and borderColor style for slider #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


borderColorclass style in favour of janky looking shaded/dotted characters for scroller/slider elements.hoverstyle for mouse over effect, it is inexpensive since the scrollbar widgets already get mouse events.get()in order to tolerate a potential for the non-existance or empty style definition.│─UTF-8 characters instead of dotted┊┄characters which look ugly on some terminals.■UTF-8 character for horizontal scroller to match the similar thickness of the vertical bar.█UTF-8 character instead of shaded▓character because no matching square is available.+ASCII symbol for scrollers because this is more readable thanXagainst the window edge borders.Using the solid lines and equal thickness bars gives a much cleaner look and more overall balance to the interface...
The narrower thickness of this horizontal scrollbar is more proportionate to the apprearence of the vertical scrollbar, this makes a large difference to the overall aesthetics balance. It is slightly segmented compared to the full block, but I think it is worth it.
The "jankyness" of the shaded/dotted scrollbar characters is especially noticable in the pyodide sandbox (TryItOnline) where the scrollbar characters do not render well at all, so I am interested to see what this improvement will look like on that platform...
The
borderColorstyle gives the flexibility needed to create a traditional "filled in" scrollbar (by using the same glyphs for both the handle and the slider but with different colors) if desired, such as is done in the screenshot of the Tree on the right.