Skip to content

Conversation

@bryan-robitaille
Copy link
Contributor

@bryan-robitaille bryan-robitaille commented Oct 17, 2025

Summary | Résumé

  • Rename .env to .env.yarn. Yarn v4 will automatically export the values into environment variables so we no longer need to rely on dot-env package. This is required now that Prisma no longer leverages the dot-env package and we need to get the database_url into process.env
  • Move and isolate the Prisma package from the application code into it's own NPM package. This will allow for Prisma to be used across out platform is the different services (Lambda, API Server) and ensure easy access to Models and their types.
  • Use a hosted github action runner with AWS Code Build to run prisma migrations in the private VPCs.

Linked to cds-snc/forms-terraform#1125

Test instructions | Instructions pour tester la modification

Should be no change to application functionality in using the Database

Unresolved questions / Out of scope | Questions non résolues ou hors sujet

  • Should we move our whole pipeline to AWS Code Build and Code Deploy?

Pull Request Checklist

Please complete the following items in the checklist before you request a review:

  • Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
  • The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
  • If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
  • Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
  • Does your code have adequate comprehensible comments? Do new functions have docstrings?
  • Have you modified the change log and updated any relevant documentation?
  • Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
  • If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

@github-actions github-actions bot added the !! Package Update !! Please ensure packages are built and pushed label Oct 17, 2025
@bryan-robitaille bryan-robitaille marked this pull request as ready for review October 22, 2025 17:35
craigzour
craigzour previously approved these changes Oct 28, 2025
Copy link
Contributor

@craigzour craigzour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!! Package Update !! Please ensure packages are built and pushed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants