feat(gcds-select): Add native HTML attributes and validation #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daine
reviewed
Nov 25, 2025
| this.internals.setFormValue(null); | ||
| this.value = null; | ||
| } | ||
| console.log('value changed to: ', this.value); |
Collaborator
There was a problem hiding this comment.
Suggested change
| console.log('value changed to: ', this.value); |
daine
reviewed
Nov 25, 2025
daine
reviewed
Nov 25, 2025
daine
reviewed
Nov 25, 2025
Co-authored-by: Daine Trinidad <[email protected]>
Co-authored-by: Daine Trinidad <[email protected]>
Co-authored-by: Daine Trinidad <[email protected]>
daine
reviewed
Nov 25, 2025
| /** | ||
| * If true, the select will be focused on component render | ||
| */ | ||
| @Prop({ reflect: true }) autofocus: boolean; |
Collaborator
There was a problem hiding this comment.
Should this be optional too? And/or have an inferred default on declaration?
Suggested change
| @Prop({ reflect: true }) autofocus: boolean; | |
| @Prop({ reflect: true }) autofocus?: false; |
Collaborator
Author
There was a problem hiding this comment.
Seems the build fails when adding a ? to the autofocus property. Luckily the property is still marked as optional even if it doesn't have a ?
daine
reviewed
Nov 25, 2025
| ${args.disabled ? `disabled` : null} | ||
| ${args.autocomplete ? `autocomplete="${args.autocomplete}"` : null} | ||
| ${args.autofocus ? `autofocus` : null} | ||
| ${args.form ? `form="${args.value}"` : null} |
Collaborator
There was a problem hiding this comment.
Should this be
Suggested change
| ${args.form ? `form="${args.value}"` : null} | |
| ${args.form ? `form="${args.form}"` : null} |
daine
reviewed
Nov 25, 2025
| ${args.disabled ? `disabled` : null} | ||
| ${args.autocomplete ? `autocomplete="${args.autocomplete}"` : null} | ||
| ${args.autofocus ? `autofocus` : null} | ||
| ${args.form ? `form="${args.value}"` : null} |
Collaborator
There was a problem hiding this comment.
Suggested change
| ${args.form ? `form="${args.value}"` : null} | |
| ${args.form ? `form="${args.form}"` : null} |
…c/gcds-components into feat/gcds-select-validity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Add attributes to match
gcds-selectbehaviour to the HTMLselectto provide additional validation.gcds-selecthas also been expanded to work with the HTML ValidityState to provide developers with more options when validatinggcds-selects and new methods to check current validation state.New properties/attributes
autofocusautofocusbooleanundefinedformformstringundefinedvalidityvalidityValidityStateundefinedNew methods
cds-snc/design-gc-conception#2022