Skip to content

798: Action to check engine against published rules#1700

Merged
gerrycampion merged 35 commits into
mainfrom
798-test-against-published
Jun 5, 2026
Merged

798: Action to check engine against published rules#1700
gerrycampion merged 35 commits into
mainfrom
798-test-against-published

Conversation

@alexfurmenkov
Copy link
Copy Markdown
Collaborator

@alexfurmenkov alexfurmenkov commented Apr 22, 2026

workflow to run validation for all published rules, comparing with benchmark validation results

cdisc-org/cdisc-open-rules#22 with changes to allow validation from this repo

Comment on lines +48 to +60
- name: Checkout cdisc-open-rules
uses: actions/checkout@v6
with:
repository: cdisc-org/cdisc-open-rules
ref: ${{ inputs.rules_ref || 'main' }}
path: open-rules
# If cdisc-open-rules is private, add a PAT secret:
# token: ${{ secrets.CDISC_OPEN_RULES_TOKEN }}

# -----------------------------------------------------------------------
# 3. Set up Python
# -----------------------------------------------------------------------
- name: Set up Python 3.12
@alexfurmenkov alexfurmenkov linked an issue Apr 28, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@gerrycampion gerrycampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really nice, but I have some comments

Comment thread .github/workflows/validate-published-rules.yml Outdated
Comment thread .github/workflows/validate-published-rules.yml Outdated
Comment thread .github/workflows/validate-published-rules.yml Outdated
Comment thread .github/workflows/validate-published-rules.yml Outdated
Copy link
Copy Markdown
Collaborator

@gerrycampion gerrycampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The summary and detailed outputs look awesome. I have one comment, sorry I didn't pickup on this earlier. Hopefully it is an easy conversion for ai.

Comment thread .github/workflows/validate-published-rules.yml Outdated
@gerrycampion gerrycampion merged commit 4afe6e2 into main Jun 5, 2026
11 checks passed
@gerrycampion gerrycampion deleted the 798-test-against-published branch June 5, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action to run all published rules' tests

5 participants