Skip to content

CI Pipeline Update #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SFJohnson24 merged 8 commits into from
Jan 13, 2026
Merged

CI Pipeline Update #1538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0e4f970
reorder readme, fix tests
SFJohnson24 Jan 8, 2026
37eee3d
Merge branch 'main' into readme
SFJohnson24 Jan 8, 2026
92eff15
merged to one test command
SFJohnson24 Jan 8, 2026
96edf4f
Restore readme.md to match main
SFJohnson24 Jan 8, 2026
0b5e23b
spell mistake
SFJohnson24 Jan 8, 2026
afea82a
update CI, remove operator from schema
SFJohnson24 Jan 13, 2026
c345f08
Merge branch 'main' into readme
SFJohnson24 Jan 13, 2026
d97c069
Auto-updated branch with latest changes from main
SFJohnson24 Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/automated-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@
with:
pr_ref: ${{ github.event.pull_request.head.sha }}
rule_tester:
if: github.event.action == 'opened'
uses: ./.github/workflows/rule-tester.yml
secrets: inherit
with:
environment: DEV
test_rule_editor_preview:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
if: github.event.action == 'opened'
needs: rule_tester
uses: ./.github/workflows/test_rule_editor_preview.yml
secrets: inherit
with:
pr_ref: ${{ github.event.pull_request.head.sha }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
7 changes: 0 additions & 7 deletions resources/schema/Operator.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,6 @@
"required": ["operator", "value"],
"type": "object"
},
{
"properties": {
"operator": { "const": "does_not_use_valid_codelist_terms" }
},
"required": ["operator", "value", "codelistlevel", "codelistcheck"],
"type": "object"
},
{
"properties": { "operator": { "const": "empty" } },
"required": ["operator"],
Expand Down
36 changes: 0 additions & 36 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,42 +907,6 @@ def dataset_rule_record_in_parent_domain_equal_to() -> dict:
}


@pytest.fixture
def define_xml_allowed_terms_check_rule() -> dict:
return {
"core_id": "MockRule",
"rule_type": "Define-XML",
"standards": [{"Name": "SDTMIG", "Version": "3.3"}],
"classes": {"Include": [ALL_KEYWORD]},
"domains": {"Include": [ALL_KEYWORD]},
"conditions": ConditionCompositeFactory.get_condition_composite(
{
"all": [
{
"name": "get_dataset",
"operator": "does_not_use_valid_codelist_terms",
"value": {
"target": "define_variable_ccode",
"comparator": "define_variable_allowed_terms",
},
}
]
}
),
"actions": [
{
"name": "generate_dataset_error_objects",
"params": {"message": "Define specifies invalid codelist terms"},
}
],
"output_variables": [
"define_variable_ccode",
"define_variable_name",
"define_variable_allowed_terms",
],
}


@pytest.fixture
def dataset_rule_inconsistent_enumerated_columns() -> dict:
"""
Expand Down
Loading