remove editor mentions#44
Open
SFJohnson24 wants to merge 4 commits into
Open
Conversation
RamilCDISC
requested changes
Jun 4, 2026
|
|
||
| If you provide a dataset AE where both AESEV and AESHOSP have empty values in a record, this rule will only flag a single error for that record, but it will display the empty values for both variables. | ||
|
|
||
| </details> |
There was a problem hiding this comment.
This belongs to previous tag is removed. Should we restore it?
| My test data dates are being treated as numbers or the engine is returning errors indicating that my dates cannot be parsed. | ||
| </summary> | ||
|
|
||
| When using Excel for data, one of the tradeoffs is that it tries to autoformat. If Excel recognizes a date, it will convert it to a numeric representation of the date and display it formatted. When the Rule Editor loads the date cell, it loads the number instead of the original text string date. You can confirm this by viewing the loaded test data section in the “Load Datasets” panel of the Rule Editor and checking if the date values are numbers instead of character strings. |
There was a problem hiding this comment.
This FAQ is still valid as excel dataset is supported with rules engine. Maybe we can just remove the mention of editor instead of the whole FAQ?
| [UI]-.->[Rule YAML Editor] | ||
| [UI]-.->[Rule Test] | ||
| [Rule YAML Editor]<->[cdisc-rules-engine-repo] | ||
| [Rule YAML Editor]<->[cdisc-open-rules-repo] |
There was a problem hiding this comment.
Do you think the name in the bracket also change? as I guess it is not an editor anymore.
| ### Schema for Rule Schematic | ||
|
|
||
| Intellisense is informed by a schema in JSON format. The editor also uses it to provide suggestions. | ||
| Intellisense is informed by a schema in JSON format. |
There was a problem hiding this comment.
Is the mention of intellisense still valid as their is no rules editor anymore? Please let me know if I am misunderstanding something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.