Skip to content

Json theme fixes#183

Open
Skosov wants to merge 27 commits intostorybook-updatefrom
json-theme-fixes
Open

Json theme fixes#183
Skosov wants to merge 27 commits intostorybook-updatefrom
json-theme-fixes

Conversation

@Skosov
Copy link
Copy Markdown
Member

@Skosov Skosov commented Apr 1, 2026

No description provided.

Skosov and others added 27 commits March 31, 2026 10:22
# Conflicts:
#	src/plugins/prime/theme3.0/css.ts
# Conflicts:
#	src/plugins/prime/theme3.0/css.ts
# Conflicts:
#	src/plugins/prime/theme3.0/css.ts
Полностью скруглённая форма кнопки.
<Canvas of={ButtonStories.Rounded} />

### Disabled
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему удаляем?

<Button label="Button" class="p-button-xlg" />
</OverlayBadge>
</div>
<OverlayBadge :value="args.value" :severity="args.badgeSeverity || args.severity">
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

код сниппет генерится не так

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

<Dialog
v-model:visible="visible"
v-bind="args"
:class="args.size"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ты описывываешь size как props, хотя такого пропса не существует у Dialog и по факту это class

}

.p-button-xlg.p-button-icon-only {
.p-button.p-component:is(.p-button-xlg, .p-button-xlarge).p-button-icon-only {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не особо понял что за xlarge класс, поэтому эти изменения не буду забирать, жду пояснения в отдельном МР для кнопок

Comment on lines +2 to +4
.p-overlaybadge {
display: inline-flex;
}
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

без измнений сториков всё и так работает

Base automatically changed from json-theme to storybook-update April 1, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant