megamenu: стилизация, сторисы#161
Open
khaliulin wants to merge 12 commits intostorybook-updatefrom
Open
Conversation
Member
обрезан пример, какое-то широкое подменю |
Collaborator
Author
Member
|
@khaliulin я не вижу в макете состояния открытого меню. Нам точно ок такая ширина? |
…ов горизонтального вида от начала пункта меню
Collaborator
Author
Skosov
reviewed
Apr 6, 2026
| font-size: 87.5%; | ||
| } | ||
| /* Specific height for Menu components previews in Docs */ | ||
| .docs-story.css-kdwx3d:has(.p-menubar), |
Member
There was a problem hiding this comment.
Не подходит такой селектор, почему нельзя высоту прям в сторе больше сделать?
Collaborator
Author
Collaborator
Author
Skosov
reviewed
Apr 6, 2026
| <small v-if="item.description" class="megamenu-item-caption">{{ item.description }}</small> | ||
| </div> | ||
| <Badge v-if="item.badge" :value="item.badge" /> | ||
| <svg v-if="item.items" width="14" height="14" viewBox="0 0 14 14" fill="none" xmlns="http://www.w3.org/2000/svg" class="p-icon p-megamenu-submenu-icon" aria-hidden="true" data-pc-section="submenuicon"><path d="M3.58659 4.5007C3.68513 4.50023 3.78277 4.51945 3.87379 4.55723C3.9648 4.59501 4.04735 4.65058 4.11659 4.7207L7.11659 7.7207L10.1166 4.7207C10.2619 4.65055 10.4259 4.62911 10.5843 4.65956C10.7427 4.69002 10.8871 4.77074 10.996 4.88976C11.1049 5.00877 11.1726 5.15973 11.1889 5.32022C11.2052 5.48072 11.1693 5.6422 11.0866 5.7807L7.58659 9.2807C7.44597 9.42115 7.25534 9.50004 7.05659 9.50004C6.85784 9.50004 6.66722 9.42115 6.52659 9.2807L3.02659 5.7807C2.88614 5.64007 2.80725 5.44945 2.80725 5.2507C2.80725 5.05195 2.88614 4.86132 3.02659 4.7207C3.09932 4.64685 3.18675 4.58911 3.28322 4.55121C3.37969 4.51331 3.48305 4.4961 3.58659 4.5007Z" fill="currentColor"></path></svg> |
Member
There was a problem hiding this comment.
А это случайно не иконка из таблера? Если да, то может прямым импортом её достать?
Collaborator
Author
Member
|
сразу решить конфликты |
Skosov
reviewed
Apr 17, 2026
| <span v-if="item.icon" :class="['p-megamenu-item-icon', item.icon]" /> | ||
| <div class="megamenu-item-label"> | ||
| <span class="p-megamenu-item-label">{{ item.label }}</span> | ||
| <small v-if="item.description" class="megamenu-item-caption">{{ item.description }}</small> |
Member
There was a problem hiding this comment.
по-моему это придуманные классы на которые потом идет стилизация
Collaborator
Author
Skosov
reviewed
Apr 17, 2026
Member
There was a problem hiding this comment.
убрать стилизацию на придуманные классы, добавить примеры в сториках как получить такие результаты
рассмотреть возможность обертки
Collaborator
Author
added 2 commits
April 21, 2026 23:01
… из megamenu.ts, decorators → story.height
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.