Skip to content

tabs: стилизация, сторисы, обёртки#46

Open
khaliulin wants to merge 7 commits intofeature/styles-debugfrom
panel.tabs
Open

tabs: стилизация, сторисы, обёртки#46
khaliulin wants to merge 7 commits intofeature/styles-debugfrom
panel.tabs

Conversation

@khaliulin
Copy link
Copy Markdown

No description provided.

>
<p-tablist>
<p-tab
*ngFor="let tab of tabs"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@for лучше, новый стандарт

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AxyIX *ngFor заменён на @for во всём шаблоне.

36fff85

[value]="tab.value"
[disabled]="tab.disabled || false"
>
<i *ngIf="tab.icon" class="text-xl" [class]="tab.icon"></i>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@if

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AxyIX *ngIf заменён на @if, импорт NgIf убран.

ee57574


// ── WithDisabled ──────────────────────────────────────────────────────────────

export const WithDisabled: Story = WithDisabledStory;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лучше сделать единообразно
export { WithBadgeStory, WithDisabledStory };

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AxyIX Экспорт приведён к единообразному виду: export { WithBadge, WithDisabled };

f92632d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants