Skip to content

Improve sidebar discoverability and selection visibility#573

Open
hoechenberger wants to merge 18 commits intocbrnr:mainfrom
hoechenberger:sidebar
Open

Improve sidebar discoverability and selection visibility#573
hoechenberger wants to merge 18 commits intocbrnr:mainfrom
hoechenberger:sidebar

Conversation

@hoechenberger
Copy link
Contributor

@hoechenberger hoechenberger commented Feb 27, 2026

image
  • Show column headers ("#" and "Name") in the sidebar table so the
    layout and index column are self-explanatory.
  • Also apply a stylesheet
    that forces the system highlight color on selected rows, which was previously rendered as an inactive gray due to Qt.NoFocus.
  • We keep Qt.NoFocus as I believe you chose this intentionally? To avoid issues with keyboard shortcuts perhaps?

Closes #566

- Show column headers ("#" and "Name") in the sidebar table so the
layout and index column are self-explanatory.
- Also apply a stylesheet
that forces the system highlight color on selected rows, which was
previously rendered as an inactive gray due to `Qt.NoFocus`.
- We keep `Qt.NoFocus` as I believe you chose this intentionally? To avoid issues with keyboard shortcuts perhaps?

Closes cbrnr#566
@cbrnr
Copy link
Owner

cbrnr commented Feb 28, 2026

TBH I can't remember the reason for making it Qt.NoFocus, but there is very likely a good reason. If you want, you could try disabling it and playing around to see what breaks.

Interestingly, the selected row uses the system highlight color on Linux/KDE, so this might be a macOS-specific thing. If that's the case, I'd prefer to apply this stylesheet only on macOS (so someone needs to check on Windows).

I'm not sure I like the column headers, mainly because there is an empty header for the third column (which includes the "Close" icon on hover). If you can make the "Name" column header span over these two columns, I think this would look better.

Also, the "Name" column header should be left-aligned (and the "#" should probably be right-aligned), so that column headers and column contents are consistently aligned.

Finally, what do you think of starting with "1" for the first data set? I think there's no benefit in exposing Python's zero-based indexing here, as this is merely a representation of the number of open data sets.

@hoechenberger
Copy link
Contributor Author

Hehe, I agree with ~everything you said :) See also #568, I think we the table alignment problem exists in many more places

@hoechenberger hoechenberger marked this pull request as draft February 28, 2026 13:18
@hoechenberger
Copy link
Contributor Author

@cbrnr Feel free to take a look! (See commit history for a list of changes)

@hoechenberger hoechenberger marked this pull request as ready for review February 28, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidebar color scheme causes UX issues

2 participants