forked from OpenMS/OpenMS
-
Notifications
You must be signed in to change notification settings - Fork 5
Abgabe #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BelaPfeffer
wants to merge
38
commits into
cbielow:develop
Choose a base branch
from
BelaPfeffer:abgabe
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Abgabe #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and output centroided mz and im peaks
… some helping functions to class StringManager
…ved performance inside the compress64 function. Edited the the XMLHandler_test to work with new implemantation and got rid of new/delete:
… Added a for loop to prevent this method from crossing page Boundaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We tired to speed up the toNative method in the XMLHandler.
Therefore we changed the implementation of appendASCII. It now uses SIMDe to process the Input in a Block of 8 chars at a time.
We added two three new methods to the StringManager Class
1.)int StringManager::strLength(const XMLCh* input_ptr)
This method uses SIMDe commands to determine the length of a Xerces String by finding the 0 iterator
2.)void StringManager::compress64(const XMLCh* inputIt, char* outputIt)
This method helps the appendASCII method to compress 8 UTF 16 char at a time down to ASCII chars also using SIMDe
3.)bool StringManager::isASCII(const XMLCh* chars, const XMLSize_t length)
This Method determines whether or not an Input is ASCII convertible or not by checking the upper bytes of a UTF 16 char.
Underlying logic : very UTF -16 char with two zeros as upper bits is ASCII convertible.
We added a XMLHandler_test where all the new methods and implementations are tested
Remaining Problems:
Remaining Problems and Benchmarks of the Project are in the pdf in the appendix
Benchmarks.pdf
Checklist
How can I get additional information on failed tests during CI
Click to expand
If your PR is failing you can check outIf you click in the column that lists the failed tests you will get detailed error messages.
Advanced commands (admins / reviewer only)
Click to expand
/reformat
(experimental) applies the clang-format style changes as additional commit. Note: your branch must have a different name (e.g., yourrepo:feature/XYZ) than the receiving branch (e.g., OpenMS:develop). Otherwise, reformat fails to push.rebuild jenkins
will retrigger Jenkins-based CI builds