Fixed ":" char appearing which is not allowed in Windows paths #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahel-sh
reviewed
Feb 18, 2025
| window_size: Optional[int] = kwargs.get("window_size", None) | ||
|
|
||
| name = self._model_coordinator.get_output_filename( | ||
| top_k_candidates, dataset_name, shuffle_candidates, **kwargs |
Member
There was a problem hiding this comment.
Please change it within get_output_filename functions in all the rerankers in case they are/will be called from other places.
If you define a helper function (get_formatted_datetime or something similar) in the root RankLLM class, then all the get_output_filename implementations can call that.
Please also do a git grep to find datetime to see if we have this problem anywhere else, since ":" in the name comes from the datetime.isoformat that we append to the output files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Reference Issue
Please provide the reference to issue this PR is addressing (# followed by the issue number). If there is no associated issue, write "N/A".
ref: #182
Checklist Items
Before submitting your pull request, please review these items:
PR Type
What kind of change does this PR introduce?