Skip to content

Apply changes from https://github.com/casper-network/casper-node/pull/5089#10

Merged
gRoussac merged 5 commits intocasper-ecosystem:masterfrom
gRoussac:binary_response_changes
Mar 25, 2025
Merged

Apply changes from https://github.com/casper-network/casper-node/pull/5089#10
gRoussac merged 5 commits intocasper-ecosystem:masterfrom
gRoussac:binary_response_changes

Conversation

@gRoussac
Copy link
Contributor

@gRoussac gRoussac commented Feb 5, 2025

Apply changes from casper-network/casper-node#5089

  • Renamed BinaryRequest to Command
  • changed BinaryResponseAndRequest so it holds responses requests raw bytes instead of derived structure

Missing : Update of example files resources/examples/*.bin

Getting request_id from BinaryResponseAndRequest request is a bit strange, I would have expected not to have to extract the request id from the request but have it in BinaryResponseHeader

@gRoussac gRoussac marked this pull request as ready for review February 6, 2025 15:39
@gRoussac
Copy link
Contributor Author

gRoussac commented Feb 6, 2025

@igor-casper @zajko Is there a process to update files in resources/examples/ ?

thanks

…rt-client into binary_response_changes

# Conflicts:
#	Cargo.lock
@gRoussac gRoussac merged commit 20424af into casper-ecosystem:master Mar 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply changes from casper-network/casper-node#5089

2 participants