extend and refactor nut11 sig_all message aggregation#811
Open
callebtc wants to merge 4 commits into
Open
Conversation
…0f93a6c055ea018cfdc1026 in nuts repo
5 tasks
robwoodgate
approved these changes
Mar 31, 2026
robwoodgate
left a comment
robwoodgate
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
I noticed there is no "happy path" test for multi-inputs (same secrets, different nonces), but this is also missing from the NUT-11 test vectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #822
changes in cashubtc/nuts#302