Avoid Postgres test fixture deadlocks#1011
Open
SatsAndSports wants to merge 2 commits into
Open
Conversation
Author
|
A small fix that helps me running tests on my laptop, might be relevant in CI too ( @a1denvalu3 ) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
- Coverage 74.99% 73.78% -1.21%
==========================================
Files 111 111
Lines 12065 12069 +4
==========================================
- Hits 9048 8905 -143
- Misses 3017 3164 +147 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #1008 , I found that some existing tests would hang locally.
This is a test-only change.
This PR avoids deadlocks in the function-scoped ledger test fixture when running the suite against Postgres. The fixture previously called ledger.startup_ledger(), which starts background tasks such as the regular maintenance loop and invoice listeners. In Postgres-backed test runs, those long-lived tasks could keep transactions open while the next test tried to reset the database with DROP SCHEMA public CASCADE, causing the suite to hang. With this PR, instead only the minimum needed functionality - no background task loops - will be started.
===
With postgres running, I run this
MINT_BACKEND_BOLT11_SAT=FakeWallet WALLET_NAME=test_wallet MINT_HOST=localhost MINT_PORT=3337 MINT_TEST_DATABASE=postgres://cashu:cashu@localhost:5432/cashu DEBUG_MINT_ONLY_DEPRECATED=false TOR=false poetry run pytest tests/mint/test_mint.py -vv -sWithout this fix, it always hangs - usually on
tests/mint/test_mint.py::test_keysets. With this fix, it never hangs