fix(core): dedupe proof watcher finalization checks#180
Open
Egge21M wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: b6093f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 84.29% 84.94% +0.65%
==========================================
Files 115 115
Lines 13928 13915 -13
==========================================
+ Hits 11740 11820 +80
+ Misses 2188 2095 -93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes redundant proof watcher send finalization checks.
Problem
Spent proof handling could trigger repeated send finalization work for the same operation. A subscription-driven spent notification already emitted a proof state event that finalized the send, and batched spent events could also repeat the operation-level check once per proof from the same send operation.
Summary
Verification
bun run --filter='@cashu/coco-core' test -- test/unit/ProofStateWatcherService.test.tsbun run --filter='@cashu/coco-core' test -- test/unit/SendOperationService.test.tsbun run --filter='@cashu/coco-core' typecheckgit diff --checkChangeset
.changeset/single-proof-finalization.md