Skip to content

fix: treat mint limit errors as definitive during issue recovery#2113

Merged
thesimplekid merged 1 commit into
cashubtc:mainfrom
thesimplekid:fix_mint_limit_error
Jun 16, 2026
Merged

fix: treat mint limit errors as definitive during issue recovery#2113
thesimplekid merged 1 commit into
cashubtc:mainfrom
thesimplekid:fix_mint_limit_error

Conversation

@thesimplekid

Copy link
Copy Markdown
Collaborator

Issue saga recovery now stops on definitive replay failures such as max output/input rejections instead of falling back to restore. Decode those mint error responses into structured variants so recovery preserves and surfaces the original failure.

Description


Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

  • I followed the code style guidelines
  • I ran just quick-check before committing
  • If the Wallet API was modified (added/removed/changed), I have reflected those changes in the FFI bindings (crates/cdk-ffi)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 411dfde52b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/cdk/src/wallet/issue/saga/resume.rs Outdated
Comment thread crates/cdk-common/src/error.rs Outdated
Comment thread crates/cdk/src/wallet/issue/saga/resume.rs Outdated
Comment thread crates/cdk/src/wallet/issue/saga/resume.rs
@thesimplekid thesimplekid force-pushed the fix_mint_limit_error branch from 411dfde to 5da5eb8 Compare June 16, 2026 10:06
@thesimplekid

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 5da5eb84f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@thesimplekid thesimplekid added this to the 0.17.1 milestone Jun 16, 2026
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.05941% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.48%. Comparing base (3171791) to head (bfb5b8d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/cdk/src/wallet/issue/saga/resume.rs 91.89% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
+ Coverage   71.41%   71.48%   +0.06%     
==========================================
  Files         356      356              
  Lines       73757    73857     +100     
==========================================
+ Hits        52676    52798     +122     
+ Misses      21081    21059      -22     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Issue saga recovery now stops on definitive replay failures
such as max output/input rejections instead of falling back to restore.
Decode those mint error responses into structured variants so recovery preserves and surfaces the original failure.
@thesimplekid thesimplekid force-pushed the fix_mint_limit_error branch from 5da5eb8 to bfb5b8d Compare June 16, 2026 12:49
@thesimplekid thesimplekid merged commit bfb5b8d into cashubtc:main Jun 16, 2026
0 of 7 checks passed
@thesimplekid thesimplekid deleted the fix_mint_limit_error branch June 16, 2026 12:49
@github-project-automation github-project-automation Bot moved this from Backlog to Done in CDK Jun 16, 2026
@cdk-bot

cdk-bot commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for v0.17.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants