chore: Removes clone from Wallet struct

[TheMhv]

Description

It's a part from #1310

Removes clone from Wallet struct

---

Notes to the reviewers

---

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

---

Checklist

• I followed the code style guidelines
• I ran just final-check before committing

[thesimplekid]

- [x] We should also check with Zeus before merging this. They created their own binding for react native that may need clone.

Turns out I don't know how react native works and they somehow pull in the cdk bindings so as long as our bindings work its okay.

[thesimplekid]

This looks pretty good I think we just need to resolve #1762 (comment)

[codecov]

Codecov Report

❌ Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.46%. Comparing base (bfb5b8d) to head (2860afc).

Files with missing lines	Patch %	Lines
crates/cdk/src/wallet/wallet_repository.rs	18.75%	13 Missing ⚠️
crates/cdk-ffi/src/wallet_repository.rs	0.00%	2 Missing ⚠️
crates/cdk/src/wallet/npubcash.rs	0.00%	2 Missing ⚠️
crates/cdk/src/wallet/payment_request.rs	0.00%	2 Missing ⚠️
crates/cdk/src/wallet/streams/npubcash.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1762      +/-   ##
==========================================
- Coverage   71.48%   71.46%   -0.02%     
==========================================
  Files         356      356              
  Lines       73857    73862       +5     
==========================================
- Hits        52798    52787      -11     
- Misses      21059    21075      +16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[lescuer97]

This message is going to get bubbled to the user of the CLI. Probably something more descriptive would help in case of debugging in the future

[lescuer97]

LGTM

[cdk-bot]

Verified findings approved for disclosure:

• update-mint-url panics when unwrapping repository Arc (medium) - The cdk-cli update-mint-url subcommand panics instead of updating the mint URL for repository-managed wallets, making the command unusable after this PR's Arc refactor.
  Unanchored locations included in summary:
  • crates/cdk/src/wallet/wallet_repository.rs:290

[cdk-bot]

Verified findings approved for disclosure:

• Repository mint URL update does not migrate persisted wallet data (high) - Updating a mint URL through the repository/CLI leaves the wallet database under the old URL, so the newly returned wallet can no longer see existing persisted balance/quotes for the mint.

[cdk-bot]

Verified findings approved for disclosure:

• update_mint_url drops the wallet if another Arc reference exists (medium) - If any consumer holds an Arc while updating a mint URL, the update fails and the repository drops the wallet from its in-memory map until it is recreated or the repository is reloaded.

[cdk-bot]

update_mint_url removes the wallet from the repository before attempting Arc::try_unwrap. Since the PR now exposes repository wallets as Arc<Wallet>, any normal caller that kept the value returned by create_wallet/get_wallet holds an additional strong reference. In that case try_unwrap fails, this method returns UnknownWallet, and the old entry has already been removed from self.wallets, so subsequent repository lookups lose the in-memory wallet.

Consider avoiding try_unwrap here, or at minimum restoring the removed Arc on the error path. A design with interior mutability / recreating and replacing the map entry without requiring unique Arc ownership would also avoid invalidating active wallet handles.