feat: fix Sendable warnings across the codebase #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…res; mark Config Sendable
Member
|
@zamderax you can fix all sendable warnings for all files in one single PR |
…in InternalApi generic; wrap FileAdapter handlers; mark Config Sendable\n\n- Adds Sendable to error enums\n- Constrains afterOperatePolicy generic T: Sendable\n- Wraps Util.* handlers in explicit @sendable closures\n- Marks Config as Sendable\n\nThis consolidates sendability fixes into one PR to address Swift 6 warnings.
zamderax
changed the title
Contributor
Author
|
@hsluoyz okay! |
Member
|
@zamderax is this all? |
Contributor
Author
|
No it's not but given my local staggered workflow, I will make a more "meatier" one later. But for now I'll silence the warnings for this branch / PR |
Member
|
@zamderax the PR is not by file, it's by feature. You should fix all Sendable warnings for all files in one PR |
hsluoyz
changed the title
Member
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce Swift 6 concurrency warnings
What changed
FileAdapterwith explicit closures to avoid Sendable conversion warningsConfigasSendable(safe since it only holds value types)Why
Testing